Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

region rule should ignore content of noscript elements #864

Closed
nico3333fr opened this issue Apr 26, 2018 · 3 comments
Closed

region rule should ignore content of noscript elements #864

nico3333fr opened this issue Apr 26, 2018 · 3 comments
Labels
fix Bug fixes

Comments

@nico3333fr
Copy link

Hi there,

I've used it on https://van11y.net/ thanks to Sonarwhal https://sonarwhal.com/scanner/39c2fa0b-cfaa-49c9-bc5f-3564a2eaec21

It reported me this error: "Content should be contained in a landmark region"

It seems (look at the thread on Twitter https://twitter.com/molant/status/989497275134001154) that it is due to:

<noscript><p class="invisible"><img src="/piwik/piwik.php?idsite=1" alt="" /></p></noscript>

This piece of code is for Matomo Analytics (ex-Piwik). It seems to be a false positive.

I hope this will help you to improve your tool.

Cheers,
Nicolas

@WilcoFiers
Copy link
Contributor

Sound legit to me 😃. Axe-core should definitely be ignoring things inside of < noscript>.

@WilcoFiers WilcoFiers added the fix Bug fixes label Apr 26, 2018
@WilcoFiers WilcoFiers changed the title False positive due to Matomo integration region rule should ignore content of noscript elements Apr 30, 2018
@jeeyyy
Copy link
Contributor

jeeyyy commented Sep 12, 2018

@WilcoFiers
I was looking to pick this up and the first point of fix was to introduces a region-matches.js for region rule and ignore noscript and its children.

But your comment reads, axe-core should ignore noscript. Am I right in thinking we need to make this a global filter of some sort, even before executing the matches?

Thoughts?

@jeeyyy
Copy link
Contributor

jeeyyy commented Nov 23, 2018

Not able to reproduce the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes
Projects
None yet
Development

No branches or pull requests

3 participants