Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make the frame timeout limit configurable #660

Closed
WilcoFiers opened this issue Dec 19, 2017 · 3 comments
Closed

make the frame timeout limit configurable #660

WilcoFiers opened this issue Dec 19, 2017 · 3 comments

Comments

@WilcoFiers
Copy link
Contributor

We had a client (issue WH-4054 on JIRA) that kept getting timeout errors while running axe on a particular page. A short term solution could be to extend this time limit. Longer term we should probably just add a feature that lets the frame report its still in progress if it's near the timeout limit. That way we can shorten the timeout too.
@dylanb
Copy link
Contributor

dylanb commented Dec 19, 2017

How about allowing a configurable timeout?

@WilcoFiers
Copy link
Contributor Author

Matt is working on that :)

isner added a commit that referenced this issue Dec 19, 2017
@isner
feat(collect-results-from-frames): add frameWaitTime option
1e72a42 
Closes #660
@isner isner mentioned this issue Dec 19, 2017
Merged
@isner
Copy link
Contributor

isner commented Dec 19, 2017

Feature added by #661

isner added a commit that referenced this issue Jan 4, 2018
@isner
feat(collect-results-from-frames): add frameWaitTime option
da1aba4 
Closes #660
marcysutton pushed a commit that referenced this issue Jan 18, 2018
@isner @marcysutton
feat(collect-results-from-frames): add frameWaitTime option (#661)
8016ad1 
Closes #660
marcysutton pushed a commit that referenced this issue Jan 18, 2018
@isner
feat(collect-results-from-frames): add frameWaitTime option (#661)
659a85b 
Closes #660
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dylanb @WilcoFiers @isner