Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACT rules IDs in Axe rules? #2820

Closed
fpetrone opened this issue Feb 26, 2021 · 4 comments
Closed

ACT rules IDs in Axe rules? #2820

fpetrone opened this issue Feb 26, 2021 · 4 comments
Labels
docs Documentation changes good first issue For first-time contributors hackathon pr A pr has been created for the issue
Milestone
axe-core 4.3

Comments

@fpetrone
Copy link

I was not able to find the ID from the ACT rules in the results that Axe shows in the console nor in the rules description.

For example, for the rule "button-name" there is the tag "ACT" but not an "ACT ID". I am not sure if that rule is linked to the ACT rule with the ID 97a4e1 .  If it is not there, I think that adding it would be a good improvement for a tool that is already great.  
@WilcoFiers
Copy link
Contributor

Thanks for asking! That's a very good point. We should put links to the corresponding ACT rules in the rule help pages I think. Haven't yet, but I'll put it on our list! Great idea.

@WilcoFiers WilcoFiers added the docs Documentation changes label Mar 4, 2021
@WilcoFiers WilcoFiers added this to the axe-core 4.2 milestone Mar 4, 2021
@fpetrone
Copy link
Author

fpetrone commented Mar 5, 2021 •
edited
Loading

Thanks for replying. I was thinking of the ID inside the object if that makes sense. In any case, it would be great to have any mapping. Cheers!

@dylanb dylanb added good first issue For first-time contributors hackathon labels Mar 11, 2021
@rweberkaf
Copy link
Contributor

Taking on this task, making the "hackathon" label true!

rweberkaf added a commit to rweberkaf/axe-core that referenced this issue Apr 6, 2021
@rweberkaf
feat(rule): add ACT Rule IDs to test rule objects (dequelabs#2820)
15df992
@rweberkaf rweberkaf mentioned this issue Apr 6, 2021
Merged
@WilcoFiers WilcoFiers modified the milestones: axe-core 4.2, axe-core 4.3 Apr 14, 2021
WilcoFiers pushed a commit that referenced this issue Apr 28, 2021
@rweberkaf
feat(rule): add ACT Rule IDs to test rule objects (#2866)
cc1ebf5 
* feat(rule): add ACT Rule IDs to test rule objects (#2820)

* docs(rule-descriptions): link from rule descriptions to ACT description pages
@straker straker added the pr A pr has been created for the issue label Jun 17, 2021
@straker
Copy link
Contributor

straker commented Jun 17, 2021

Was resolved in #2866

@straker straker closed this as completed Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation changes good first issue For first-time contributors hackathon pr A pr has been created for the issue
Projects
None yet
Milestone
axe-core 4.3
Development

No branches or pull requests
5 participants
@dylanb @WilcoFiers @straker @fpetrone @rweberkaf