Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify svg-non-empty-title fail message #2452

Closed
WilcoFiers opened this issue Aug 14, 2020 · 2 comments
Closed

Clarify svg-non-empty-title fail message #2452

WilcoFiers opened this issue Aug 14, 2020 · 2 comments
Labels
good first issue For first-time contributors rule metadata Issues in the rule metadata code (lib/rules)

Comments

@WilcoFiers
Copy link
Contributor

There are two things which will cause the svg-non-empty-title check to fail. Either the SVG does not have a title, or the title is empty. The fail message only describes the first case. This can be confusing. We can fix this by using messageKey and splitting the fail message into two.

Info on how to do this is described in a closely related issue #2451
@WilcoFiers WilcoFiers added good first issue For first-time contributors rule metadata Issues in the rule metadata code (lib/rules) labels Aug 14, 2020
42tte added a commit to 42tte/axe-core that referenced this issue Aug 17, 2020
@42tte
feat(svg-non-empty-title): update fail message
e6fbd68 
Update fail message to indicate if the title element is empty or missing

Closes issue dequelabs#2452
@42tte 42tte mentioned this issue Aug 17, 2020
Merged
2 tasks
straker pushed a commit that referenced this issue Aug 19, 2020
@42tte
fix(svg-non-empty-title): update fail message to indicate if the titl…
5b4a935 
…e element is empty or missing (#2462)

Update fail message to indicate if the title element is empty or missing

Closes issue #2452
@padmavemulapati
Copy link

padmavemulapati commented Aug 24, 2020 •
edited
Loading

Verified with the test file <svg id="target" ></svg> , which is having no titile , and also
<svg id="target"><title></title></svg> , which has empty title, in both cases i am not seeing any failure message.

straker pushed a commit that referenced this issue Sep 8, 2020
@42tte @straker
fix(svg-non-empty-title): update fail message to indicate if the titl…
9598656 
…e element is empty or missing (#2462)

Update fail message to indicate if the title element is empty or missing

Closes issue #2452
@straker
Copy link
Contributor

straker commented Sep 25, 2020

No docs required

@straker straker closed this as completed Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue For first-time contributors rule metadata Issues in the rule metadata code (lib/rules)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@WilcoFiers @straker @padmavemulapati