Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure message for meta-viewport rule is unclear #1045

Closed
liloda opened this issue Aug 3, 2018 · 1 comment
Closed

Failure message for meta-viewport rule is unclear #1045

liloda opened this issue Aug 3, 2018 · 1 comment
Labels
support

Comments

@liloda
Copy link

liloda commented Aug 3, 2018 •
edited
Loading

One of our users found this failure message confusing:
Fix the following: <meta> tag disables zooming on mobile devices

Suggest mentioning the attribute that actually causes the problem (user-scalable=no), something like this:
Fix the following: user-scalable="no" on <meta> tag disables zooming
marcysutton pushed a commit that referenced this issue Aug 7, 2018
fix(meta-viewport): show attribute in message
c86df60 
Closes #1045
@marcysutton marcysutton mentioned this issue Aug 7, 2018
Merged
4 tasks
marcysutton pushed a commit that referenced this issue Aug 7, 2018
fix(meta-viewport): show attribute in message
9538e81 
Closes #1045
@marcysutton
Copy link
Contributor

I submitted a PR to fix this: #1061

marcysutton pushed a commit that referenced this issue Aug 8, 2018
fix(meta-viewport): show attribute in message
f30fefa 
Closes #1045
marcysutton pushed a commit that referenced this issue Aug 9, 2018
fix(meta-viewport): show attribute in message
713c481 
Closes #1045
marcysutton pushed a commit that referenced this issue Aug 9, 2018
fix(meta-viewport): show attribute in message
545dfaa 
Closes #1045
WilcoFiers pushed a commit that referenced this issue Aug 16, 2018
@marcysutton @WilcoFiers
fix(meta-viewport): Show attribute in message (#1061)
9ff5d54 
A user reported the meta-viewport check had a confusing failure message, so I changed it to pass along the failing attribute:

"Fix the following: user-scalable="no" on <meta> tag disables zooming"

Closes #1045

## Reviewer checks

**Required fields, to be filled out by PR reviewer(s)**
- [x] Follows the commit message policy, appropriate for next version
- [x] Has documentation updated, a DU ticket, or requires no documentation change
- [x] Includes new tests, or was unnecessary
- [x] Code is reviewed for security by: Jey (@JKODU)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcysutton @liloda