-
Notifications
You must be signed in to change notification settings - Fork 791
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
82d43a0
commit bc0dd22
Showing
5 changed files
with
141 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
{ | ||
"id": "aria-tooltip-name", | ||
"selector": "[role=\"tooltip\"]", | ||
"matches": "aria-form-field-name-matches", | ||
"tags": ["wcag2a", "wcag412"], | ||
"metadata": { | ||
"description": "Ensures every ARIA tooltip node has an accessible name", | ||
"help": "ARIA tooltip ndoes must have an accessible name" | ||
}, | ||
"all": [], | ||
"any": [ | ||
"aria-label", | ||
"aria-labelledby", | ||
"non-empty-title", | ||
"has-visible-text" | ||
], | ||
"none": [] | ||
} |
26 changes: 26 additions & 0 deletions
26
test/integration/rules/aria-tooltip-name/aria-tooltip-name.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
<!-- PASS --> | ||
<div id="pass1" role="tooltip">Copy this content</div> | ||
<div id="pass2" role="tooltip" title="Copy this content"></div> | ||
<div id="pass3" role="tooltip" aria-label="Copy this content"></div> | ||
<div id="pass4" role="tooltip" aria-labelledby="copy"></div> | ||
|
||
<div id="copy">Copy this content</div> | ||
|
||
<!-- FAIL --> | ||
<div id="fail1" role="tooltip"></div> | ||
<div id="fail2" role="tooltip" aria-labelledby="copy-non-existant"></div> | ||
<div id="fail3" role="tooltip" aria-labelledby="copy-empty"></div> | ||
|
||
<div id="copy-empty"></div> | ||
|
||
<!-- INAPPLICABLE --> | ||
<img role="tooltip" alt="Label" id="inapplicable1" /> | ||
<input role="tooltip" title="Label" id="inapplicable2" /> | ||
<button role="tooltip" title="Label" id="inapplicable3"></button> | ||
<a href="#" role="tooltip" title="Label" id="inapplicable4"></a> | ||
<select role="tooltip" title="Label" id="inapplicable5"> | ||
<option value="volvo">Volvo</option> | ||
<option value="saab">Saab</option> | ||
<option value="opel">Opel</option> | ||
</select> | ||
<textarea role="tooltip" id="inapplicable6" title="Label"></textarea> |
7 changes: 7 additions & 0 deletions
7
test/integration/rules/aria-tooltip-name/aria-tooltip-name.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"description": "aria-tooltip-name test", | ||
"rule": "aria-tooltip-name", | ||
"passes": [["#pass1"], ["#pass2"], ["#pass3"], ["#pass4"]], | ||
"violations": [["#fail1"], ["#fail2"], ["#fail3"]], | ||
"incomplete": [] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,89 @@ | ||
describe('aria-tooltip-name', function() { | ||
it('should pass for aria-label', function() { | ||
var node = new axe.SerialVirtualNode({ | ||
nodeName: 'div', | ||
attributes: { | ||
role: 'tooltip', | ||
'aria-label': 'foobar' | ||
} | ||
}); | ||
node.parent = null; | ||
|
||
var results = axe.runVirtualRule('aria-tooltip-name', node); | ||
|
||
assert.lengthOf(results.passes, 1); | ||
assert.lengthOf(results.violations, 0); | ||
assert.lengthOf(results.incomplete, 0); | ||
}); | ||
|
||
it('should incomplete for aria-labelledby', function() { | ||
var node = new axe.SerialVirtualNode({ | ||
nodeName: 'div', | ||
attributes: { | ||
role: 'tooltip', | ||
'aria-labelledby': 'foobar' | ||
} | ||
}); | ||
node.parent = null; | ||
|
||
var results = axe.runVirtualRule('aria-tooltip-name', node); | ||
|
||
assert.lengthOf(results.passes, 0); | ||
assert.lengthOf(results.violations, 0); | ||
assert.lengthOf(results.incomplete, 1); | ||
}); | ||
|
||
it('should pass for title', function() { | ||
var node = new axe.SerialVirtualNode({ | ||
nodeName: 'div', | ||
attributes: { | ||
role: 'tooltip', | ||
title: 'foobar' | ||
} | ||
}); | ||
// children are required since titleText comes after subtree text | ||
// in accessible name calculation | ||
node.children = []; | ||
node.parent = null; | ||
|
||
var results = axe.runVirtualRule('aria-tooltip-name', node); | ||
|
||
assert.lengthOf(results.passes, 1); | ||
assert.lengthOf(results.violations, 0); | ||
assert.lengthOf(results.incomplete, 0); | ||
}); | ||
|
||
it('should fail when aria-label contains only whitespace', function() { | ||
var node = new axe.SerialVirtualNode({ | ||
nodeName: 'div', | ||
attributes: { | ||
role: 'tooltip', | ||
'aria-label': ' \t \n ' | ||
} | ||
}); | ||
node.children = []; | ||
|
||
var results = axe.runVirtualRule('aria-tooltip-name', node); | ||
|
||
assert.lengthOf(results.passes, 0); | ||
assert.lengthOf(results.violations, 1); | ||
assert.lengthOf(results.incomplete, 0); | ||
}); | ||
|
||
it('should fail when title is empty', function() { | ||
var node = new axe.SerialVirtualNode({ | ||
nodeName: 'div', | ||
attributes: { | ||
role: 'tooltip', | ||
title: '' | ||
} | ||
}); | ||
node.children = []; | ||
|
||
var results = axe.runVirtualRule('aria-tooltip-name', node); | ||
|
||
assert.lengthOf(results.passes, 0); | ||
assert.lengthOf(results.violations, 1); | ||
assert.lengthOf(results.incomplete, 0); | ||
}); | ||
}); |