Skip to content

Commit

Permalink
chore: Update duplicate-id based on feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
WilcoFiers committed Aug 24, 2018
1 parent 22d5ba7 commit 5a855df
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 4 deletions.
2 changes: 1 addition & 1 deletion lib/checks/parsing/duplicate-id-aria.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"impact": "critical",
"messages": {
"pass": "Document has no elements referenced with ARIA or labels that share the same id attribute",
"fail": "Document has multiple elements referenced with ARIA or with the same id attribute: {{=it.data}}"
"fail": "Document has multiple elements referenced with ARIA with the same id attribute: {{=it.data}}"
}
}
}
4 changes: 2 additions & 2 deletions lib/checks/parsing/duplicate-id.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"metadata": {
"impact": "minor",
"messages": {
"pass": "Document has no elements that share the same id attribute",
"fail": "Document has multiple elements with the same id attribute: {{=it.data}}"
"pass": "Document has no static elements that share the same id attribute",
"fail": "Document has multiple static elements with the same id attribute"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,14 @@

<button id="fail1" class="fail1"></button>
<button id="fail1"></button>
<input id="fail2" class="fail2" />
<input id="fail2" />
<textarea id="fail3" class="fail3"></textarea>
<textarea id="fail3"></textarea>
<select id="fail4" class="fail4"></select>
<select id="fail4"></select>
<div tabindex="0" id="fail5" class="fail5"></div>
<div tabindex="0" id="fail5"></div>

<input id="pass1" />
<textarea id="pass2"></textarea>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"description": "duplicate-id-active test",
"rule": "duplicate-id-active",
"violations": [[".fail1"]],
"violations": [[".fail1"], [".fail2"], [".fail3"], [".fail4"], [".fail5"]],
"passes": [["#pass1"], ["#pass2"], ["#pass3"], ["#pass4"]]
}

0 comments on commit 5a855df

Please sign in to comment.