fix(utils.matches): fix attribute exists selector to match empty attr…

…ibutes (#3669) * fix(utils.matches): fix attribute exists selector to match empty attributes * comments * Update test/core/utils/matches.js Co-authored-by: Wilco Fiers <[email protected]> * Update test/core/utils/matches.js Co-authored-by: Wilco Fiers <[email protected]> Co-authored-by: Wilco Fiers <[email protected]>
dequelabs · Sep 26, 2022 · 4b768ea · 4b768ea
1 parent 3f3edd6
commit 4b768ea
Show file tree

Hide file tree

Showing 2 changed files with 98 additions and 69 deletions.
diff --git a/lib/core/utils/matches.js b/lib/core/utils/matches.js
@@ -16,7 +16,7 @@ function matchesAttributes(vNode, exp) {
     !exp.attributes ||
     exp.attributes.every(att => {
       var nodeAtt = vNode.attr(att.key);
-      return nodeAtt !== null && (!att.value || att.test(nodeAtt));
+      return nodeAtt !== null && att.test(nodeAtt);
     })
   );
 }
@@ -108,9 +108,10 @@ function convertAttributes(atts) {
           return attributeValue !== value;
         };
         break;
+      // attribute existence
       default:
         test = value => {
-          return !!value;
+          return value !== null;
         };
     }