fix: medium bug #91
Merged
fix: medium bug #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sujin-kk
commented
Jun 25, 2022
Comment on lines
+40
to
+43
| BindingAdapter.setLinkify( | ||
| binding.contactInstagramTv, | ||
| getString(R.string.fairer_instagram), | ||
| getString(R.string.fairer_instagram_link)) |
There was a problem hiding this comment.
문의하기에서 인스타그램에 하이퍼링크를 달아 웹뷰로 띄우는 작업을 진행했습니다.
나중에 필요시 pattern도 인자로 넘겨 커스텀할 수 있을것같습니다.
지메일은 오토링크로 처리했습니다.
Comment on lines
+190
to
+191
| val groupSize:Int = it.members.size | ||
| _groupName.value = "${it.teamName} $groupSize" |
There was a problem hiding this comment.
Comment on lines
+147
to
+149
| 0 -> { | ||
| binding.tvCompleteHouseChore.text = getString(R.string.complete_chore_yet) | ||
| } |
There was a problem hiding this comment.
Comment on lines
+56
to
+60
| val curSelectedAssignees = bottomSheetAssigneeAdapter.getSelectedAssignees() | ||
| when { | ||
| selectedAssignees.isNotEmpty() -> { | ||
| curSelectedAssignees.isNotEmpty() -> { | ||
| addAssignee() | ||
| mOkBtnClickListener.onOkBtnClick() |
There was a problem hiding this comment.
Comment on lines
12
to
+26
| "Mon" -> DayString.Mon.korDay | ||
| "월" -> DayString.Mon.korDay | ||
| "Tue" -> DayString.Tue.korDay | ||
| "화" -> DayString.Tue.korDay | ||
| "Wed" -> DayString.Wed.korDay | ||
| "수" -> DayString.Wed.korDay | ||
| "Thu" -> DayString.Thu.korDay | ||
| "목" -> DayString.Thu.korDay | ||
| "Fri" -> DayString.Fri.korDay | ||
| "금" -> DayString.Fri.korDay | ||
| "Sat" -> DayString.Sat.korDay | ||
| "토" -> DayString.Sat.korDay | ||
| "Sun" -> DayString.Sun.korDay | ||
| else -> DayString.Mon.korDay | ||
| "일" -> DayString.Sun.korDay | ||
| else -> DayString.ETC.korDay |
There was a problem hiding this comment.
메인화면에서 공간 선택화면으로 넘어갈 때 요일표기가 이상한 문제 수정했습니다.
버전차이인지, 제 애뮬레이터(API 29) 에서는 DateFormat의 요일값이 "Mon" 영어로 반환되고,
실기기에서는 요일값이 "월" 한글로 반환되는 문제였습니다.
Comment on lines
+12
to
+27
| fun getVibrator(context: Context) { | ||
| try { | ||
| val vibrator = if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) { | ||
| val vibratorManager = | ||
| context.getSystemService(Context.VIBRATOR_MANAGER_SERVICE) as VibratorManager | ||
| vibratorManager.defaultVibrator | ||
| } | ||
| else { | ||
| @Suppress("DEPRECATION") | ||
| context.getSystemService(VIBRATOR_SERVICE) as Vibrator | ||
| } | ||
| vibrator.vibrate(VibrationEffect.createOneShot(1000, 100)) | ||
| } catch (e: Exception) { | ||
| e.printStackTrace() | ||
| } | ||
| } |
There was a problem hiding this comment.
진혁님이 집안일 생성시 타임피커 건드릴때마다 진동오게할수있냐고 하셔서 만들어뒀는데, 아직 실기기로 테스트 전입니다 ㅜ.ㅜ
There was a problem hiding this comment.
이거는 추후 개선으로 합시다. 타임피커 건들떄마다 진동오는건 지금 중요한 이슈는 아닌것 같아요 ㅠㅠ
sujin-kk
commented
Jun 25, 2022
Comment on lines
+221
to
+232
| private fun sortAssignees(allAssignees: ArrayList<Assignee>): ArrayList<Assignee> { | ||
| val temp = arrayListOf<Assignee>() | ||
| allAssignees.map { assignee -> | ||
| if(assignee.memberId == PrefsManager.memberId) { | ||
| temp.add(0, assignee) | ||
| } | ||
| else { | ||
| temp.add(assignee) | ||
| } | ||
| } | ||
| return temp | ||
| } |
There was a problem hiding this comment.
|
수고하셨습니다 수진님 수정된 내용들은 테스트로 넘겨주시면 좋을 것 같아요 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
미디엄 레벨 위주로 자잘한 버그 수정했습니다. 하이 레벨 위주로 이제 작업할 예정입니다.
코드 리뷰로 노션 링크 올리겠습니다