feature 규칙 화면 #80
Merged
feature 규칙 화면 #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjdwns
approved these changes
Jun 23, 2022
| @@ -20,19 +20,22 @@ interface ApiService { | |||
| suspend fun getCompletedHouseWorkNumber(@Query("scheduledDate") scheduledDate: String): CompleteHouseWork | |||
|
|
|||
| @POST("/api/oauth/login") | |||
| suspend fun googleLogin(@Header("Authorization")auth : String, @Body socialType : SocialType): LoginResponse | |||
|
|
|||
| suspend fun googlelogin(@Body socialType : SocialType): LoginResponse | |||
There was a problem hiding this comment.
main브런치에서 고쳤던걸 develop브런치에서 수정을 안했었군요,,, 에러가 여태껏 안난게 기적..
| } | ||
| } | ||
|
|
||
| binding.etRule.setOnKeyListener { v, keyCode, event -> |
There was a problem hiding this comment.
focus out 때문에 걱정 많이 했는데 키보드 액션으로 처리하셨군요 최고십니다...!
| .runCatching { | ||
| collect { | ||
| if (it.code == 200) { | ||
| getRules() |
There was a problem hiding this comment.
나중에 네트워크 처리할 생각으로 저도 onfail까지 작성해두었습니다 네트워크 처리 다 해줘야겠죠...?
There was a problem hiding this comment.
일단 runCatching 걸어줘서 괜찮을것 같은데 network Error 처리는 우선순위 낮춰서 가져가도 될것 같아요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.