feat: 하우스 관리 페이지 #72
Merged
feat: 하우스 관리 페이지 #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sujin-kk
commented
Jun 18, 2022
sujin-kk
commented
- 하우스 관리 페이지 구현
- 하우스 이름 변경 화면 sign view type 넘겨 연결
- 초대 코드 화면 invite view type 넘겨 연결 -> 하우스 관리 통해 초대코드 화면 볼때는 건너뛰기 버튼 없도록 구현
- 각종 화면 string 처리 (SpannableString), 피그마랑 달라진 부분 수정
|
|
|
제가 CI가 계속 google_serivece.json파일로 인해 실패하여서 임의로 추가하였는데 gitignore해주셔서 감사합니다 ^^7 |
wjdwns
approved these changes
Jun 19, 2022
| val toast = Toast.makeText(requireContext(), "코드를 클립보드에 복사했습니다.", Toast.LENGTH_SHORT) | ||
| toast.setGravity(Gravity.CENTER, Gravity.CENTER_HORIZONTAL, Gravity.CENTER_VERTICAL) | ||
| toast.show() | ||
| Toast.makeText(requireContext(), getString(R.string.invite_code_copy_toast_text), Toast.LENGTH_SHORT).show() |
There was a problem hiding this comment.
제 코드에서는 초대코드 실험하기 위해서 수정해놓은 것이니 주석처리해놓고 작업해놓겠습니당
| package com.depromeet.housekeeper.model.enums | ||
|
|
||
| enum class InviteViewType { | ||
| SIGN, SETTING |
| @@ -67,7 +67,7 @@ | |||
| android:id="@+id/join_group_make_space_info_image" | |||
| android:layout_width="wrap_content" | |||
| android:layout_height="wrap_content" | |||
| android:src="@drawable/ic_info" | |||
| android:src="@drawable/ic_info_fill" | |||
There was a problem hiding this comment.
ㅋㅋㅋㅋ네이밍이 겹쳤군요! 수정해주셔서 감사합니다
| @@ -10,16 +10,17 @@ | |||
| <Button | |||
| android:id="@+id/main_footer_button" | |||
| android:layout_width="match_parent" | |||
| android:layout_height="46dp" | |||
| android:layout_height="56dp" | |||
…to feature/house-setting-page pull develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.