Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/divide_view #66

Merged
merged 19 commits into from
Jun 11, 2022
Merged

Feature/divide_view #66

merged 19 commits into from
Jun 11, 2022

Conversation

wjdwns
Copy link
Collaborator

@wjdwns wjdwns commented Jun 11, 2022

분기처리 브런치 새로 나누어서 PR 올립니다~!

@wjdwns wjdwns self-assigned this Jun 11, 2022
@wjdwns wjdwns requested review from sujin-kk June 11, 2022 07:50
@onemask
Copy link
Collaborator

onemask commented Jun 11, 2022

@wjdwns
Ci fail 나서 확인 필요해보입니닷

Copy link
Collaborator

@onemask onemask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI fail 확인 필요해보입니닷

Copy link
Member

@sujin-kk sujin-kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어요!

Comment on lines +31 to +48
@androidx.databinding.BindingAdapter("app:signViewType")
@JvmStatic
fun signViewType(textView: TextView, signViewType:SignViewType){
when(signViewType){
SignViewType.UserName -> {
textView.setText(R.string.sign_name_text)
}
SignViewType.GroupName -> {
textView.setText(R.string.group_name_text)
}
SignViewType.InviteCode -> {
textView.setText(R.string.invite_code_text)
}
SignViewType.ModifyGroupName -> {
textView.setText(R.string.modify_group_name_text)
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

분기처리 좋습니다

@wjdwns wjdwns merged commit 8393478 into develop Jun 11, 2022
@wjdwns wjdwns deleted the feature/divide_view branch June 11, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants