feat header 에 token 적용 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjdwns
approved these changes
May 19, 2022
| override fun onCreate() { | ||
| super.onCreate() | ||
| PrefsManager.init(applicationContext) |
There was a problem hiding this comment.
datastore도 이런식으로 사용될 수 있는지에 대해 고민을 좀 해보아야하겠군요
| @@ -102,6 +103,7 @@ class LoginFragment : Fragment() { | |||
| viewModel.response.collect { response -> | |||
| Timber.d("accesstoken:${response?.accessToken}, refreshtoken:${response?.refreshToken}") | |||
| response?.run { | |||
| PrefsManager.setTokens(response.accessToken, response.refreshToken) | |||
| DataStoreRepository( | |||
| DataStoreManager(requireContext())).saveAccessToken( | |||
| response.accessToken | |||
There was a problem hiding this comment.
아래의 datastore코드는 일부러 남겨놓으신걸까요?
| proceed( | ||
| request().newBuilder() | ||
| .addHeader("AUTHORIZATION", PrefsManager.accessToken) | ||
| .build() |
There was a problem hiding this comment.
인터셉터 사용은 처음보는데 여러방면에서 사용하기 좋은놈이군요
|
수고하셨습니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SharedPreference 에 token 값 저장하여
interceptor 이용하여 token 값 넣어주었습니다.