Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/statistics: 통계 뷰 작업 완료 #164

Merged
merged 31 commits into from
May 11, 2023
Merged

Conversation

mjkim1019
Copy link
Collaborator

@mjkim1019 mjkim1019 commented May 3, 2023

Overview

통계 화면 랭킹 뷰, 집안일 현황 뷰 완성

Details

  • Ranker View: margin을 programmatically로 구현하여 넣음 (BindingAdapter 작동 안했기 때문,,😢)
  • 집안일 현황 리스트: Flexbox 사용하여 멤버 한 줄 넘어가면 늘어나게 하였음

Todo

  • 월 누르면 다른 월로 이동하여 해당 월의 통계볼 수 있게
  • 집안일 현황 리스트 데이터 논의 필요
  • 멤버 리스트 어떻게 보여줄 것인가 논의 필요

이유: drop 할 때 한번에 다 가져오는 시간복잡도 < 할 때마다 loading 생기는 것
비용이 위와 같이 될 것이라 판단
@mjkim1019 mjkim1019 requested a review from wjdwns May 3, 2023 07:42
@@ -77,4 +80,16 @@ object BindingAdapter {
imageButton.isSelected = selected
}

@androidx.databinding.BindingAdapter("app:rankBottomMargin")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 잘 해결 된건가요???

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

결국 적용이 안돼서 이건 사용하지 못했습니다ㅜㅜ

Copy link
Collaborator

@wjdwns wjdwns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

뷰 해결 잘 된건가요?? 수고하셨습니다!

@mjkim1019
Copy link
Collaborator Author

BindingAdapter가 뷰에 적용이 안돼서 대신 해당 Adapter에서 뷰 처리하는 방식으로 뷰 구현했습니다ㅜㅜ

@mjkim1019 mjkim1019 merged commit 320c108 into develop May 11, 2023
@mjkim1019 mjkim1019 deleted the feature/statistics branch May 11, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants