Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/feedback #163

Merged
merged 20 commits into from
May 11, 2023
Merged

Feature/feedback #163

merged 20 commits into from
May 11, 2023

Conversation

wjdwns
Copy link
Collaborator

@wjdwns wjdwns commented Apr 30, 2023

피드백 관련 화면 전부 작업 완료했습니다.

@wjdwns wjdwns added the enhancement New feature or request label Apr 30, 2023
@wjdwns wjdwns requested a review from mjkim1019 April 30, 2023 09:21
@wjdwns wjdwns self-assigned this Apr 30, 2023
@@ -38,7 +42,11 @@ class HouseWorkAdapter(
}

fun callDone(layoutPosition: Int) {
onDone.invoke(list[layoutPosition])
onDone.invoke(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invoke가 어떻게 사용하는 기능인가요?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onDone을 호출합니다.

}

companion object {
const val TAG = "ModalBottomSheet"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HouseKeeperConst.kt 로 이동시켜주세요!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

android:visibility="@{emojiNum==0?View.VISIBLE:View.GONE}"
android:textSize="14sp"
android:textColor="@color/black"
tool:text="창문 틈새 어쩌구~!"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋ 어쩌구~!

}
}

private val Int.dpToPx:Int
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

util > DpPxUtil 파일에 만들어 놓았긴 했었어요..!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인하고 수정하겠습니다.

@wjdwns wjdwns merged commit 00e802e into develop May 11, 2023
@wjdwns wjdwns deleted the feature/feedback branch May 11, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants