Fix/bug navigation : Navigation 관련 에러 해결 #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 0.0.5
* remove header * update header * add AuthCode * remove requestLogin authCode * add setAuthCode
� Conflicts: � app/proguard-rules.pro � app/src/main/java/com/depromeet/housekeeper/LoginFragment.kt � app/src/main/java/com/depromeet/housekeeper/LoginFragmentViewModel.kt � app/src/main/java/com/depromeet/housekeeper/data/RetrofitBuilder.kt � app/src/main/java/com/depromeet/housekeeper/local/PrefsManager.kt � app/src/main/java/com/depromeet/housekeeper/network/remote/api/ApiService.kt � app/src/main/java/com/depromeet/housekeeper/network/remote/api/RemoteDataSource.kt � app/src/main/java/com/depromeet/housekeeper/network/remote/repository/Repository.kt � app/src/main/java/com/depromeet/housekeeper/ui/addDirectTodo/AddDirectTodoViewModel.kt � keystore
… 나가는 현상 exception else로 처리
…ation action/destination 오류 해결
navigateSafe가 필요하지 않을 것 같은 부분은 그냥 그대로 두었습니다..!
sujin-kk
approved these changes
Aug 18, 2022
| @@ -178,7 +179,7 @@ class AddDirectTodoFragment : Fragment() { | |||
| setOnClickListener { | |||
| updateChore() | |||
| viewModel.createHouseWorks() | |||
| it.findNavController().navigate(R.id.action_addDirectTodoFragment_to_mainFragment) | |||
| it.findNavController().navigateSafe(R.id.action_addDirectTodoFragment_to_mainFragment) | |||
There was a problem hiding this comment.
[Q] navigateSafe를 하게 되면 어떻게 달라지나요?
There was a problem hiding this comment.
[A] navigateSafe 함수에서 A->B위치로 이동하는 action이 있는지 확인 후 navigate 합니다.
따라서 중복 호출되어 이미 B위치로 넘어갔을 땐 B->B이므로 navigate가 호출되지 않아 error가 발생하지 않습니다.
Comment on lines
+46
to
+57
| val bundle = Bundle().apply { | ||
| putSerializable(NAVIGATION_VIEW_TYPE, SignViewType.GroupName) | ||
| putString(NAVIGATION_CODE, null) | ||
| } | ||
| findNavController().navigateSafe(R.id.action_joinGroupFragment_to_signNameFragment, bundle) | ||
| } | ||
| binding.joinGroupJoinSpaceButton.setOnClickListener { | ||
| findNavController().navigate(JoinGroupFragmentDirections.actionJoinGroupFragmentToSignNameFragment(SignViewType.InviteCode,null)) | ||
| val bundle = Bundle().apply { | ||
| putSerializable(NAVIGATION_VIEW_TYPE, SignViewType.InviteCode) | ||
| putString(NAVIGATION_CODE, null) | ||
| } | ||
| findNavController().navigateSafe(R.id.action_joinGroupFragment_to_signNameFragment, bundle) |
Fix/profile rounded
…Android into fix/bug_navigation
wjdwns
added a commit
that referenced
this pull request
Aug 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.notion.so/ba85f01273f14ac3b3aeaeb991d7aa59
다음 화면으로 이동하는 button 두 번이상 클릭했을 때 앱 죽는 현상
[Error] java.lang.IllegalArgumentException: Navigation action/destination
Navigation 기능에 대한 연속적인 호출이 원인