Feature/refactoring #119
Merged
Feature/refactoring #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 이동 & PrefsManager.kt util 폴더 내로 이동 MainFragment.kt와 연결된 MainViewModel과 MainActivity.kt와 연결된 MainViewModel이 존재하여 중복된 이름 피하고자 이름 변경
…taSourceImpl와 RemoteRepository 생성 app architecture guide(https://developer.android.com/topic/architecture/data-layer#in-memory-cache)에 따라 변경 - repository는 데이터 영역의 진입점 (ui와 왔다 갔다 하는 클래스) - dataSource는 Room이나 API 받아 오는 곳 - todo 및 구현은 Hilt 사용하면서 진행할 예정
- ui 폴더 제가 생각하는 기능별로 분류했습니다! 의견은 언제나 환영입니다! - 기존 MainActivity 이름에 혼잡성이 있다고 판단하여 HouseKeeperActivity로 이름 변경하였습니다. - network -> data로 변경하였고 이 안에서 local/remote/repository로 나누었습니다. - PrefsManager는 util 폴더로 이동하였습니다. (보통 local에서는 local database인 room을 사용하는 것 같아서요!)
mjkim1019
requested review from
wjdwns and
sujin-kk
and removed request for
wjdwns
|
수고하셨습니다!! 근데 첫 커밋에 파일을 빠뜨린게 뭐에요?? |
MainActivity를 HouseActivity로 바꾼거를 commit 안했었어요 |
sujin-kk
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor : ui folder 기능별로 organize & data와 관련된 folder 정리