Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Member 도메인 설계 #3

Merged
merged 10 commits into from
May 3, 2024
Merged

feat: Member 도메인 설계 #3

merged 10 commits into from
May 3, 2024

Conversation

CChuYong
Copy link
Member

@CChuYong CChuYong commented May 2, 2024

💡 기능

  • Member 도메인 엔티티 구체화
  • 사용자 생성, 비밀번호 변경, 기본 비밀번호 설정 UseCase 추가
  • 기본 예외, SpringWeb 기초 설정 등
  • UseCase 유닛 테스트 (KoTest)

🔎 기타

보일러플레이팅과 함께 멤버쪽 빠르게 나가보았습니다!
보시다가 킹받는 부분 있으시면 마구마구 찔러주세용
그라운드룰 정할 시간이 넉넉치 않아서 서로 pr하면서 맞춰가야할것같아용

@CChuYong CChuYong requested a review from ddingmin as a code owner May 2, 2024 03:30
Copy link

github-actions bot commented May 2, 2024

Auto labels applied based on the title of the PR.

Copy link
Member

@ddingmin ddingmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

생각보다 시간이 없군여.. 주말에 열심히 할게요 ㅠㅠ

코멘트들은 취향이라.. 편하신대로 해서 머지해주세영

Comment on lines 4 to 6
val generationId: Int,
val role: MemberRole,
val position: MemberPosition,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기수 별 조가 필요해보이네여

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추가했습니다!

@CChuYong CChuYong merged commit dfe5d34 into develop May 3, 2024
@CChuYong CChuYong deleted the feature/#2 branch May 3, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants