Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Attendance 도메인 재설계, 출석 기능 구현 #15

Merged
merged 2 commits into from
May 15, 2024

Conversation

ddingmin
Copy link
Member

💡 기능

  • Attendace 도메인을 따로 재설계했습니다.
  • 출석에 대한 기능을 구현했습니다.
    • 온라인, 오프라인

🔎 기타

  • 정책에 따라 추후 변경될 부분에 주석처리 해두었습니다.

@ddingmin ddingmin requested a review from CChuYong as a code owner May 15, 2024 01:55
Copy link

Auto labels applied based on the title of the PR.

return jpaAttendanceRepository
.findByMemberIdAndGenerationAndWeek(memberId, generation, week)
?.toDomain()
?: throw NoSuchElementException("해당하는 회원의 세대, 주차 출석 정보가 없습니다.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그냥 터뜨려도 문제없는 케이스인거죵??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 존재하지 않으면 기본 출석 정보 객체를 할당합니다!

@ddingmin ddingmin merged commit bcb699c into develop May 15, 2024
1 check passed
@ddingmin ddingmin deleted the feature/#15 branch May 15, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants