Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OING-383] refact: saveVoiceComment RequestBody 변경 #281

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

Ji-soo708
Copy link
Member

@Ji-soo708 Ji-soo708 commented Jan 7, 2025

❓ 기능 추가 배경


프론트의 요청으로 기존에 사용하던 CreatePostCommentRequest 대신 CreatePostVoiceCommentRequest로 수정했습니다

➕ 추가/변경된 기능


  • saveVoiceComment RequestBody 변경

🥺 리뷰어에게 하고싶은 말


확인해주세요~

🔗 참조 or 관련된 이슈


https://no5ing.atlassian.net/browse/OING-383

🔗 참조 or 관련된 이슈


https://no5ing.atlassian.net/browse/OING-383

@Ji-soo708 Ji-soo708 self-assigned this Jan 7, 2025
@Ji-soo708 Ji-soo708 added the ♻️ REFACTORING 리팩토링 label Jan 7, 2025
@Ji-soo708 Ji-soo708 requested a review from CChuYong January 7, 2025 14:19
@github-actions github-actions bot changed the title refact: saveVoiceComment RequestBody 변경 [OING-383] refact: saveVoiceComment RequestBody 변경 Jan 7, 2025
Copy link
Member

@CChuYong CChuYong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

github-actions bot commented Jan 7, 2025

Test Results

 52 files   52 suites   12s ⏱️
146 tests 146 ✅ 0 💤 0 ❌
147 runs  147 ✅ 0 💤 0 ❌

Results for commit 98f4b3c.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 7, 2025

Code Coverage

File Coverage [55.83%]
CreatePostVoiceCommentRequest.java 100% 🍏
VoiceCommentService.java 72.73%
VoiceCommentController.java 16.88%
Total Project Coverage 52.18% 🍏

Copy link

sonarqubecloud bot commented Jan 7, 2025

@Ji-soo708 Ji-soo708 merged commit 3d5bc95 into dev Jan 7, 2025
5 checks passed
@Ji-soo708 Ji-soo708 deleted the feature/OING-383 branch January 7, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants