Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OING-294] refactor: 캐싱 기능 및 Redis 설정 파일 삭제 #218

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

Ji-soo708
Copy link
Member

@Ji-soo708 Ji-soo708 commented Mar 27, 2024

❓ 기능 추가 배경


비용 문제로 Redis 제거하기로 결정해서 캐싱 기능과 레디스 설정 파일을 삭제했습니다

➕ 추가/변경된 기능


  • 캐싱 기능 제거
  • Redis 설정 파일 삭제

🥺 리뷰어에게 하고싶은 말


레디스와 관련있는 기능인 포스트 작성, 캘린더 조회 모두 정상 동작되고 테스트까지 통과되는 지 확인했습니다~

🔗 참조 or 관련된 이슈


https://no5ing.atlassian.net/browse/OING-294

@Ji-soo708 Ji-soo708 self-assigned this Mar 27, 2024
@github-actions github-actions bot changed the title refactor: 캐싱 기능 및 Redis 설정 파일 삭제 [OING-294] refactor: 캐싱 기능 및 Redis 설정 파일 삭제 Mar 27, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Test Results

 40 files   40 suites   10s ⏱️
105 tests 105 ✅ 0 💤 0 ❌
106 runs  106 ✅ 0 💤 0 ❌

Results for commit d0bc7d3.

Copy link

Code Coverage

File Coverage [75.41%]
CalendarResponse.java 100% 🍏
CalendarController.java 77.65%
PostController.java 62.5%
Total Project Coverage 51.58% 🍏

@Ji-soo708 Ji-soo708 requested review from Kwon770 and CChuYong March 27, 2024 08:38
Copy link
Member

@CChuYong CChuYong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다. DEV 나가고 캐싱 쓰는 기능들 다 정상적으로 동작하는지 한번만 확인 부탁드려요!

@CChuYong CChuYong merged commit 94aa103 into dev Mar 27, 2024
4 checks passed
@CChuYong CChuYong deleted the feature/OING-294 branch March 27, 2024 10:00
@Ji-soo708
Copy link
Member Author

확인했습니다. DEV 나가고 캐싱 쓰는 기능들 다 정상적으로 동작하는지 한번만 확인 부탁드려요!

확인했는데 정상동작합니다!

CChuYong pushed a commit that referenced this pull request Apr 2, 2024
* feature: delete redis file and caching logic

* feature: delete redis env value

* test: delete redis file in test

* chore: delete library related to redis
CChuYong pushed a commit that referenced this pull request Apr 3, 2024
* feature: delete redis file and caching logic

* feature: delete redis env value

* test: delete redis file in test

* chore: delete library related to redis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants