remove 3rd party support, as will be handled in rector core

src/FileSystem/TemplateFileSystem.php

@@ -19,18 +19,6 @@ final class TemplateFileSystem
      */
     private const FIXTURE_SHORT_REGEX = '#/Fixture/#';
 
-    /**
-     * @var string
-     * @see https://regex101.com/r/HBcfXd/1
-     */
-    private const PACKAGE_RULES_PATH_REGEX = '#(rules)\/__Package__#i';
-
-    /**
-     * @var string
-     * @see https://regex101.com/r/HBcfXd/1
-     */
-    private const PACKAGE_RULES_TESTS_PATH_REGEX = '#(rules-tests)\/__Package__#i';
-
     public function __construct(
         private readonly TemplateFactory $templateFactory,
         private readonly Filesystem $filesystem,
@@ -49,13 +37,6 @@ public function resolveDestination(
         $destination = $this->resolveRelativeFilepath($filePath);
         $destination = $this->changeRootPathForRootPackage($rectorRecipe, $destination);
 
-        // normalize core package
-        if (! $rectorRecipe->isRectorRepository()) {
-            // special keyword for 3rd party Rectors, not for core Github contribution
-            $destination = Strings::replace($destination, self::PACKAGE_RULES_PATH_REGEX, 'utils/rector/src');
-            $destination = Strings::replace($destination, self::PACKAGE_RULES_TESTS_PATH_REGEX, 'utils/rector/tests');
-        }
-
         $destination = $this->templateFactory->create($destination, $templateVariables);
 
         // remove ".inc" protection from PHPUnit if not a test case

src/Generator/FileGenerator.php

@@ -13,18 +13,6 @@
 
 final class FileGenerator
 {
-    /**
-     * @var string
-     * @see https://regex101.com/r/RVbPEX/1
-     */
-    private const RECTOR_UTILS_REGEX = '#Rector\\\\Utils#';
-
-    /**
-     * @var string
-     * @see https://regex101.com/r/RVbPEX/1
-     */
-    private const RECTOR_UTILS_TESTS_REGEX = '#Rector\\\\Tests\\\\Utils#';
-
     public function __construct(
         private readonly Filesystem $filesystem,
         private readonly TemplateFactory $templateFactory,
@@ -77,12 +65,6 @@ private function generateFileInfoWithTemplateVariables(
 
         $content = $this->templateFactory->create($templateFileContents, $templateVariables);
 
-        // replace "Rector\Utils\" with "Utils\Rector\" for 3rd party packages
-        if (! $rectorRecipe->isRectorRepository()) {
-            $content = Strings::replace($content, self::RECTOR_UTILS_REGEX, 'Utils\Rector');
-            $content = Strings::replace($content, self::RECTOR_UTILS_TESTS_REGEX, 'Utils\Rector\Tests');
-        }
-
         // correct tests PSR-4 namespace for core rector packages
         if (in_array($rectorRecipe->getPackage(), Packages::RECTOR_CORE, true)) {
             $content = Strings::replace(

src/ValueObject/RectorRecipe.php

@@ -4,7 +4,6 @@
 
 namespace Rector\RectorGenerator\ValueObject;
 
-use Nette\Utils\Json;
 use Nette\Utils\Strings;
 use PhpParser\Node;
 use PhpParser\Node\Expr\FuncCall;
@@ -25,8 +24,6 @@ final class RectorRecipe
 
     private ?string $codeAfter = null;
 
-    private bool $isRectorRepository;
-
     private ?string $category = null;
 
     /**
@@ -50,8 +47,6 @@ public function __construct(
         string $codeBefore,
         string $codeAfter
     ) {
-        $this->isRectorRepository = $this->detectRectorRepository();
-
         $this->setPackage($package);
         $this->setName($name);
         $this->setNodeTypes($nodeTypes);
@@ -99,26 +94,11 @@ public function getCodeAfter(): string
         return $this->codeAfter;
     }
 
-    public function isRectorRepository(): bool
-    {
-        return $this->isRectorRepository;
-    }
-
     public function getCategory(): string
     {
         return $this->category;
     }
 
-    /**
-     * For testing purposes
-     *
-     * @api
-     */
-    public function setIsRectorRepository(bool $isRectorRepository): void
-    {
-        $this->isRectorRepository = $isRectorRepository;
-    }
-
     /**
      * For tests
      *
@@ -204,34 +184,4 @@ private function normalizeCode(string $code): string
 
         return trim($code);
     }
-
-    private function detectRectorRepository(): bool
-    {
-        $possibleComposerJsonFilePaths = [
-            __DIR__ . '/../../../../../composer.json',
-            __DIR__ . '/../../composer.json',
-        ];
-
-        foreach ($possibleComposerJsonFilePaths as $possibleComposerJsonFilePath) {
-            if (! file_exists($possibleComposerJsonFilePath)) {
-                continue;
-            }
-
-            $composerJsonContent = file_get_contents($possibleComposerJsonFilePath);
-            if ($composerJsonContent === false) {
-                continue;
-            }
-
-            $composerJson = Json::decode($composerJsonContent, Json::FORCE_ARRAY);
-            if (! isset($composerJson['name'])) {
-                continue;
-            }
-
-            if (\str_starts_with((string) $composerJson['name'], 'rector/')) {
-                return true;
-            }
-        }
-
-        return false;
-    }
 }

tests/RectorGenerator/RectorGeneratorTest.php

@@ -7,7 +7,6 @@
 use Nette\Utils\FileSystem;
 use Rector\RectorGenerator\Generator\RectorGenerator;
 use Rector\RectorGenerator\Tests\RectorGenerator\Source\StaticRectorRecipeFactory;
-use Rector\RectorGenerator\ValueObject\RectorRecipe;
 use Rector\Testing\PHPUnit\AbstractLazyTestCase;
 use Symfony\Component\Finder\Finder;
 use Symfony\Component\Finder\SplFileInfo;
@@ -37,7 +36,7 @@ protected function tearDown(): void
 
     public function test(): void
     {
-        $rectorRecipe = $this->createConfiguration(__DIR__ . '/Source/config/some_set.php', true);
+        $rectorRecipe = StaticRectorRecipeFactory::createRectorRecipe();
         $this->rectorGenerator->generate($rectorRecipe, self::DESTINATION_DIRECTORY);
 
         $fileInfos = $this->findFileInfos(__DIR__ . '/Fixture/expected/');
@@ -52,28 +51,6 @@ public function test(): void
         }
     }
 
-    public function test3rdParty(): void
-    {
-        $rectorRecipe = $this->createConfiguration(__DIR__ . '/Source/config/some_set.php', false);
-        $this->rectorGenerator->generate($rectorRecipe, self::DESTINATION_DIRECTORY);
-
-        $fileInfos = $this->findFileInfos(__DIR__ . '/Fixture/expected_3rd_party/');
-
-        foreach ($fileInfos as $fileInfo) {
-            $this->assertFileExists(self::DESTINATION_DIRECTORY . '/' . $fileInfo->getRelativePathname());
-
-            $this->assertFileEquals(
-                $fileInfo->getRealPath(),
-                self::DESTINATION_DIRECTORY . '/' . $fileInfo->getRelativePathname()
-            );
-        }
-    }
-
-    private function createConfiguration(string $setFilePath, bool $isRectorRepository): RectorRecipe
-    {
-        return StaticRectorRecipeFactory::createRectorRecipe($setFilePath, $isRectorRepository);
-    }
-
     /**
      * @return SplFileInfo[]
      */

tests/RectorGenerator/Source/StaticRectorRecipeFactory.php

@@ -14,13 +14,8 @@
  */
 final class StaticRectorRecipeFactory
 {
-    public static function createRectorRecipe(string $setFilePath, bool $isRectorRepository): RectorRecipe
+    public static function createRectorRecipe(): RectorRecipe
     {
-        if (! file_exists($setFilePath)) {
-            $message = sprintf('Set file path "%s" was not found', $setFilePath);
-            throw new ShouldNotHappenException($message);
-        }
-
         $rectorRecipe = new RectorRecipe(
             'Utils',
             'WhateverRector',
@@ -40,10 +35,7 @@ public static function createRectorRecipe(string $setFilePath, bool $isRectorRep
 CODE_SAMPLE
         );
 
-        $rectorRecipe->setIsRectorRepository($isRectorRepository);
-        if ($isRectorRepository) {
-            $rectorRecipe->setPackage('ModeratePackage');
-        }
+        $rectorRecipe->setPackage('ModeratePackage');
 
         return $rectorRecipe;
     }