Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #329: Use sudo on cleanup #330

Closed
wants to merge 3 commits into from

Conversation

leandrogehlen
Copy link
Contributor

No description provided.

@antonmedv
Copy link
Member

Why we need sudo for cleanup?

@antonmedv antonmedv closed this Jun 11, 2015
@antonmedv antonmedv reopened this Jun 11, 2015
@leandrogehlen
Copy link
Contributor Author

any news about this issue?

@antonmedv
Copy link
Member

Hi! I'm still don see any purpose for this =(.
But you can always override tasks. And create your own common recipe with this sudo stuff (and push it to GitHub to other can use it).
I think we need keep common.php recipe simple ass possible. And this is complicate it.
.

@antonmedv antonmedv closed this Aug 23, 2015
@diimpp
Copy link

diimpp commented Feb 20, 2017

@Elfet Sometimes configuring the same deployer/webserver user is not an option. For example I've managed plesk environment and this feature seems pretty relevant to me.

@antonmedv
Copy link
Member

@diimpp okay, will implement it)

@christianse2
Copy link

His this already been implemented?

@antonmedv
Copy link
Member

Not yet.

@antonmedv antonmedv reopened this Mar 9, 2017
@antonmedv
Copy link
Member

Can somebody refactor this and rebase?

@leandrogehlen
Copy link
Contributor Author

I can do

@kslimani
Copy link

kslimani commented Mar 21, 2017

What is missing for this feature to be merged ? (minus styleci warnings)
Nevermind just saw recipe/common.php conflict.
@leandrogehlen can you refactor and rebase ? 👍

@antonmedv
Copy link
Member

And send it to next branch, all work is there.

antonmedv added a commit that referenced this pull request Mar 26, 2017
@antonmedv
Copy link
Member

Done after 654 days!

@antonmedv antonmedv closed this Mar 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants