Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and use new release_or_current_path #2486

Merged
merged 3 commits into from
Apr 3, 2021

Conversation

lorisleiva
Copy link
Contributor

@lorisleiva lorisleiva commented Apr 3, 2021

As discussed in PR #2485, This PR enables users to run tasks outside a deployment by providing a new release_or_current_path option.

This option will always return the release_path if it exists and fallback to the current_path if it doesn't.

That way, outside of deployment, we can still run dep my:task and expect our task to be executed on the latest active release.

This PR replaces the use of release_path with release_or_current_path in all the custom tasks of platform-specific recipes — like laravel, symfony, etc. It also replaces the use of release_path in the deploy:vendor task, allowing users to run composer install on the current release if they need to.

Let me know if there are other places that would benefit from this new path.

Let me know what you think. 🙂


  • Bug fix #…?
  • New feature?
  • BC breaks? No, the existing behaviour stays the same but we're adding the possibility to also run tasks directly to the current release.
  • Deprecations?
  • Tests added?
  • Changelog updated?

@antonmedv
Copy link
Member

Awesome! Thanks for also fixed other recipes as well! Will release a new beta right now.

@antonmedv antonmedv merged commit 7627f9b into deployphp:master Apr 3, 2021
@Tobion Tobion mentioned this pull request Jul 15, 2021
isleshocky77 added a commit to isleshocky77/deployer that referenced this pull request Jan 16, 2023
Updating this task to use release_or_current_path (from deployphp#2486)  will allow the writable task to be used outside of deployment
antonmedv pushed a commit that referenced this pull request Jan 16, 2023
Updating this task to use release_or_current_path (from #2486)  will allow the writable task to be used outside of deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants