Added Exception Handling for perhaps missing config param #1677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* moving the name column to the last position to show full name - bug fix: #1579 * add changelog * update changelog.md * update CHANGELOG.md * modify command to find http user * modify command to find http user * modify wrong ticket url
* Remove magento:enable from Magento 2 recipe Magento's module states are stored in app/etc/config.php. This task ignored that and blindly enabled all installed modules. * Mention the removal of magento:enable in the changelog
* Added option cleanup_tty to allow allocation when using sudo * Added comment for new option cleanup_tty to CHANGELOG
* Change drupal:settings task to drupal:configure * Drupal 7 recipe - Set template file path * Changelog
#1624) * Fixed once() tasks that where being run multiple times with ParallelExecutor * CHANGELOG: reorder issue * Add test case for parallel deploy on ->once() task
* Added option cleanup_tty to allow allocation when using sudo * Added comment for new option cleanup_tty to CHANGELOG * Added cleanup_use_sudo option to all commands in cleanup.php
* Add Prestashop 1.6 recipe * Update changelog
* Sleep between progress status calls to prevent 100% CPU usage * Add changelog entry * Typo in changelog entry * Update ParallelExecutor.php * Update ParallelExecutor.php
* Detect CI user * Update CHANGELOG.md
* deploy:writable: chgrp doesn't need http_user * Update CHANGELOG.md
Sometimes deploy_path is not set and a cd into this folder is not possible. But the deployment can be successful without it.
antonmedv
requested changes
Aug 21, 2018
recipe/deploy/update_code.php
Outdated
| @@ -77,7 +77,13 @@ | |||
| } | |||
| } | |||
|
|
|||
| cd('{{deploy_path}}'); | |||
| try { | |||
There was a problem hiding this comment.
I think it's better to check with if (has('deploy_path')) {
recipe/deploy/update_code.php
Outdated
| cd('{{deploy_path}}'); | ||
| } catch (\Exception $e) { | ||
| // Deploy_path is not set | ||
| writeln("➤ Deploy_Path is not set. -> won't cd into it"); |
There was a problem hiding this comment.
And I thing we don't need logging here.
Sometimes deploy_path is not set and a cd into this folder is not possible. But the deployment can be successful without it.
|
done - fixed according to your feedback. still works :) can be merged ? |
|
Cool! Please update changelog too. |
added 2 commits
September 5, 2018 13:28
|
oh sry - forgot that. hope its ok now https://github.com/zuernBernhard/deployer/blob/patch-1/CHANGELOG.md |
antonmedv
approved these changes
Sep 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes deploy_path is not set and a cd into this folder is not possible. But the deployment can be successful without it.