Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix charges/invoices listing by using stripe API as suggested in http… #1

Merged
merged 1 commit into from
Feb 8, 2019

Conversation

ivellios
Copy link

@ivellios ivellios commented Feb 8, 2019

What's this PR do?

As described in pinax#623 invoices is no longer available in the pulled stripe customer data, thus pulling invoices list from the stripe API separately with customer id. Suggested by @polski-g in his comment: https://github.com/pinax/pinax-stripe/issues/623\#issuecomment-455814540

Same goes for charges as noted by the user in the comment.

Any background context you want to provide?

What ticket or issue # does this fix?

Closes pinax#623

Definition of Done (check if considered and/or addressed):

  • Are all backwards incompatible changes documented in this PR?
  • Have all new dependencies been documented in this PR?
  • Has the appropriate documentation been updated (if applicable)?
  • Have you written tests to prove this change works (if applicable)?

@ivellios ivellios merged commit 7bfe909 into master Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot sync customers - KeyError Invoices
2 participants