Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Nuget multi update #8908

Closed
wants to merge 38 commits into from
Closed

Fix Nuget multi update #8908

wants to merge 38 commits into from

Conversation

trejjam
Copy link
Contributor

@trejjam trejjam commented Jan 26, 2024 •
edited
Loading

I was trying to make nuget native updater work.

I could use some help if you provide me with dependencies that should be updated together and are not to be put to tests.

Also, I would appreciate a review for the dotnet part since this repository is mainly with ruby code.

I need to update how dotnet is invoked from ruby, the changes in dotnet should be complete.

Fixes #8888
Fixes #8576
Fixes #8740

@trejjam trejjam requested a review from a team as a code owner January 26, 2024 16:29
@github-actions github-actions bot added the L: dotnet:nuget NuGet packages via nuget or dotnet label Jan 26, 2024
@trejjam trejjam marked this pull request as draft January 26, 2024 16:29
@trejjam trejjam mentioned this pull request Jan 26, 2024
Closed
1 task
@trejjam trejjam force-pushed the feature/nuget-multi-update branch from 3aecc6c to 37f85d8 Compare January 26, 2024 16:31
@trejjam trejjam mentioned this pull request Jan 27, 2024
Closed
1 task
@trejjam trejjam force-pushed the feature/nuget-multi-update branch from 5129055 to fc10691 Compare January 27, 2024 16:19
@trejjam trejjam marked this pull request as ready for review January 27, 2024 16:25
@trejjam trejjam requested a review from a team as a code owner January 27, 2024 16:25
@trejjam trejjam mentioned this pull request Jan 27, 2024
Closed
1 task
@edgarrs
Copy link

edgarrs commented Jan 29, 2024

@trejjam , thank you for your contributions. Could you please break down your PR in scoped smaller PRs so we can take a look at them?

@trejjam trejjam force-pushed the feature/nuget-multi-update branch 2 times, most recently from f77e988 to 49429b1 Compare January 29, 2024 17:57
@trejjam
Copy link
Contributor Author

trejjam commented Jan 29, 2024

Ok first part extracted into: #8927

@trejjam
Copy link
Contributor Author

trejjam commented Jan 29, 2024

Another #8928

@trejjam trejjam force-pushed the feature/nuget-multi-update branch 2 times, most recently from f864b0f to 5e20bcd Compare January 29, 2024 20:22
@trejjam
Copy link
Contributor Author

trejjam commented Jan 29, 2024

And the last one, #8930.

The #8930 conflicts a lot with #8908. I prefer to go through #8930 first.

@trejjam trejjam force-pushed the feature/nuget-multi-update branch from 5e20bcd to 97bf2ec Compare February 7, 2024 17:35
@IsaacMarovitz
Copy link

@trejjam Could you resolve the conflicts on this PR

@trejjam trejjam force-pushed the feature/nuget-multi-update branch 3 times, most recently from 4e8ca4b to efab241 Compare February 11, 2024 18:27
@trejjam trejjam requested a review from tombiddulph February 11, 2024 19:25
@trejjam
Copy link
Contributor Author

trejjam commented Feb 11, 2024

It should be ready for a review

@thomhurst
Copy link

This branch has conflicts that must be resolved

@trejjam trejjam force-pushed the feature/nuget-multi-update branch from fccfbd8 to 7359fef Compare February 16, 2024 13:59
@trejjam
Copy link
Contributor Author

trejjam commented Feb 16, 2024

It was resolved at the time of my request.

@trejjam trejjam force-pushed the feature/nuget-multi-update branch from cc50c2e to 3d8badb Compare February 16, 2024 14:22
@trejjam trejjam force-pushed the feature/nuget-multi-update branch from 8c8e561 to a985814 Compare February 22, 2024 19:46
@IshakAtLEGO
Copy link

Hi
Any news on this PR? When do you expect to see it merged?

@NugetPackage
Copy link

Hi!

Any news on this PR? When do you expect to see it merged?

@abdulapopoola
Copy link
Member

Thanks everyone!

@sebasgomez238 shipped #9228 yesterday and it might already address this issue. Could you please confirm?

Tagging @trejjam , @IshakAtLEGO and @NugetPackage

@mburumaxwell
Copy link
Contributor

Grouped updates work as expected as of the last 24 hours thanks to #9228

@NugetPackage
Copy link

Thanks everyone!

@sebasgomez238 shipped #9228 yesterday and it might already address this issue. Could you please confirm?

Tagging @trejjam , @IshakAtLEGO and @NugetPackage

Will keep in touch when I have verified this, thanks for the update @abdulapopoola.

@IshakAtLEGO
Copy link

Just verified it and it works as expected. Thanx everyone.

@abdulapopoola
Copy link
Member

Thank you so much @trejjam for all the help over several weeks.

I'm closing this PR since multiple folks now confirm that it works as expected. Please consider filling new issues if they pop up.

And again, deepest gratitudeto @trejjam !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeRobich JoeRobich JoeRobich left review comments

@brettfo brettfo brettfo left review comments

@tombiddulph tombiddulph Awaiting requested review from tombiddulph

Assignees
No one assigned
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet
Projects
None yet
Milestone
No milestone