-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pipenv from 2023.8.28 to 2023.11.15 in /python/helpers #8087
Bump pipenv from 2023.8.28 to 2023.11.15 in /python/helpers #8087
Conversation
f5a20bc
to
ac6fff2
Compare
A newer version of pipenv exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
7f1ba6b
to
9d71c7f
Compare
Tricky upgrade but this should be now ready! |
Not quite passing yet, actually. Some errors are now hidden under |
Upstream issue for that change is pypa/pipenv#2791, and I think it was caused by pypa/pipenv#5897. |
9d71c7f
to
81a8d9d
Compare
Customer reported an issue The actual issue is in the tomlkit library. The fix has been released 20h before in the tomlkit 0.12.3 While upgrading this PR, we need to make sure, we are upgrading the pipenv to a version which will have the tomlkit version 0.12.3 or above. Till now pipenv version |
b2d86b9
to
4526c6e
Compare
Ok, finally got this one ready! And I also created a PR to pipenv to upgrade their tomlkit vendored version at pypa/pipenv#6024. |
4526c6e
to
ef96109
Compare
@@ -71,11 +71,12 @@ def dependency_name | |||
|
|||
def pipenv_env_variables |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated but seems like this should be a constant (let's leave as is for now though)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, maybe it took a parameter at some point or something 🤷♂️.
From 2023.9.1, pipenv uses this by default, so these changes are to get ready for that. They need a couple of tweaks, namely: * Slight tweak in the expected output, since "could not be resolved" is no longer included in verbose mode. * Explicitly set a high `COLUMNS` as ENV so that line wrapping does not get in the middle of parsing errors.
We now use verbose mode, so no more error masking.
Bumps [pipenv](https://github.com/pypa/pipenv) from 2023.8.28 to 2023.9.8. - [Release notes](https://github.com/pypa/pipenv/releases) - [Changelog](https://github.com/pypa/pipenv/blob/main/CHANGELOG.md) - [Commits](pypa/pipenv@v2023.8.28...v2023.9.8) --- updated-dependencies: - dependency-name: pipenv dependency-type: direct:production update-type: version-update:semver-minor ... Upgrade required the following changes: * Move GitDependencyReferenceNotFound regexp match to happen earlier so that the error does not get miscategorized as a generic resolution error. * Adapt the GitDependenciesNotReachable regexp to match what pipenv now runs. Signed-off-by: dependabot[bot] <[email protected]>
It only requires a small expectation change to catch up a small spacing change in pip's output.
ef96109
to
8ab2814
Compare
Bumps pipenv from 2023.8.28 to 2023.9.8.
Release notes
Sourced from pipenv's releases.
Changelog
Sourced from pipenv's changelog.
... (truncated)
Commits
cdbb2c1
Release v2023.9.8d54f11e
Pass editable for vcs when specified (#5928)9d470b4
ignore_compatibility was supposed to default to False (#5926)1e07814
Merge branch 'main' of github.com:pypa/pipenv06151cf
man pages wouldn't build which made release difficult11b50ab
Bumped version.778b8ed
Release v2023.9.730e0fa7
reference markdown format4a85f0b
Fallback to default vcs ref and determine package name from the pip line wher...91743a6
Better handling of local file install edge cases; handle local file extras (#...You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)NOTE: PR was edited to bump all the way to 2023.11.15.