Add option to control PR description max length + set reasonable defaults for each platform#7487

Merged

jeffwidman merged 29 commits intodependabot:mainfrom dwc0011:dwc0011/truncate_codecommit_pr_description

Jul 25, 2023

+139-84

Commits on Jul 25, 2023

Add truncate_pr_description and align rescue properly in fetch_file_contents method

dwc0011
authored and
jeffwidman
committed
Add specs for truncate method

dwc0011
authored and
jeffwidman
committed
use stubbed client

dwc0011
authored and
jeffwidman
committed
Use client

dwc0011
authored and
jeffwidman
committed
Fix logic on comparing truncated strings

dwc0011
authored and
jeffwidman
committed
Move truncate to message builder and pass in the default values if no values have been set for max length or encoding

dwc0011
authored and
jeffwidman
committed
Remove spec that was unintentionally added

dwc0011
authored and
jeffwidman
committed
Remove the old pr description tests

dwc0011
authored and
jeffwidman
committed
Reuse properly configured builder

dwc0011
authored and
jeffwidman
committed
Fix reference to undefined variable

dwc0011
authored and
jeffwidman
committed
Add setter for new fields

dwc0011
authored and
jeffwidman
committed
Fix setters

dwc0011
authored and
jeffwidman
committed
return msg

dwc0011
authored and
jeffwidman
committed
Add consistency to how max length is used, create encode variable

dwc0011
authored and
jeffwidman
committed
Fix lint and add param to encode

dwc0011
authored and
jeffwidman
committed
Remove useless ||=

dwc0011
authored and
jeffwidman
committed
reference instance variables correctly and add missing pr_message_encoding attribute

dwc0011
authored and
jeffwidman
committed
Add return if message is not nil

dwc0011
authored and
jeffwidman
committed
Reword comment

dwc0011
authored and
jeffwidman
committed
add mention of why encoding is an option and what the return value will be

dwc0011
authored and
jeffwidman
committed
Rename variables

dwc0011
authored and
jeffwidman
committed
Add comment

dwc0011
authored and
jeffwidman
committed
Update common/lib/dependabot/pull_request_creator/azure.rb
jeffwidman
committed
Update common/lib/dependabot/pull_request_creator/github.rb
jeffwidman
committed
Update common/lib/dependabot/pull_request_creator/codecommit.rb
jeffwidman
committed
Update common/lib/dependabot/pull_request_creator/github.rb
jeffwidman
committed
Remove old variable that is now in pull_request_creator

dwc0011
authored and
jeffwidman
committed
Update common/lib/dependabot/pull_request_creator/codecommit.rb
jeffwidman
committed
Update common/lib/dependabot/pull_request_creator/azure.rb
jeffwidman
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add option to control PR description max length + set reasonable defaults for each platform#7487

Commits on Jul 25, 2023

Add truncate_pr_description and align rescue properly in fetch_file_contents method

Add specs for truncate method

use stubbed client

Use client

Fix logic on comparing truncated strings

Move truncate to message builder and pass in the default values if no values have been set for max length or encoding

Remove spec that was unintentionally added

Remove the old pr description tests

Reuse properly configured builder

Fix reference to undefined variable

Add setter for new fields

Fix setters

return msg

Add consistency to how max length is used, create encode variable

Fix lint and add param to encode

Remove useless ||=

reference instance variables correctly and add missing pr_message_encoding attribute

Add return if message is not nil

Reword comment

add mention of why encoding is an option and what the return value will be

Rename variables

Add comment

Update common/lib/dependabot/pull_request_creator/azure.rb

Update common/lib/dependabot/pull_request_creator/github.rb

Update common/lib/dependabot/pull_request_creator/codecommit.rb

Update common/lib/dependabot/pull_request_creator/github.rb

Remove old variable that is now in pull_request_creator

Update common/lib/dependabot/pull_request_creator/codecommit.rb

Update common/lib/dependabot/pull_request_creator/azure.rb