Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize pyenv install logic #5985

Merged
merged 2 commits into from
Oct 27, 2022
Merged

Centralize pyenv install logic #5985

merged 2 commits into from
Oct 27, 2022

Conversation

pavera
Copy link
Contributor

@pavera pavera commented Oct 27, 2022

Context

As part of the work to allow Dependabot to work reliably when isolated from the internet some code cleanup has been identified. This is the beginning of the work to limit the places where we make attempts to talk to the public internet

Approach

I've added a new helpers.rb for python which will contain various methods which are currently copy/pasted between the various python package manager implementations. The first method I've moved over is the method that installs new python versions via pyenv install.

Ongoing

I am pretty sure the python_version and the methods it calls in the various implementations can also be moved to the new helpers.rb and I will be working on that next.

@pavera pavera requested a review from a team as a code owner October 27, 2022 17:38
Copy link
Contributor

@honeyankit honeyankit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@pavera
Copy link
Contributor Author

pavera commented Oct 27, 2022

@mctofu will this log as you are expecting to allow us to search in a central place?

@pavera pavera merged commit aa78f70 into main Oct 27, 2022
@pavera pavera deleted the pavera/python-install-logging branch October 27, 2022 18:40
@pavera pavera mentioned this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants