Actually consider development dependencies #5969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
deivid-rodriguez/actuall-consider-dev-deps
branch
from
3f06a79 to
266038a
Compare
|
I reverted the additional commit to drop development dependencies from subgems, since CI showed it's actually needed. |
deivid-rodriguez
changed the title
jurre
approved these changes
Oct 25, 2022
With this change, the dependency on rubocop 1.36.0 is actually pulled, so that's what's now installed in the dev image, rather than the latest version. The problem that, unless you use the `gemspec` source, other Bundler sources, like `path:`, will never pull development dependencies.
deivid-rodriguez
force-pushed
the
deivid-rodriguez/actuall-consider-dev-deps
branch
from
266038a to
f031a89
Compare
deivid-rodriguez
deleted the
deivid-rodriguez/actuall-consider-dev-deps
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue reported by @jeffwidman at #5966 (comment).
Namely, we have a
~> 1.36.0constraint on RuboCop, and still with the1.37.0release of it, now we're getting it installed in our development image.The problem is fixed by 266038a6e63a4f2a49587f57feb72093d45cbf54, by I figured if development dependencies for subgems don't buy us much, so we can unify everything in the omnibus Gemfile.