Yarn Berry: Fully update cache and include .pnp.cjs in PR #5964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavera
force-pushed
the
pavera/update-cache-if-zero-install
branch
from
39d0e2d to
b92525d
Compare
jurre
approved these changes
Oct 24, 2022
bdragon
approved these changes
Oct 24, 2022
pavera
force-pushed
the
pavera/update-cache-if-zero-install
branch
from
2e7b838 to
dc5d8d6
Compare
jurre
approved these changes
Oct 25, 2022
pavera
force-pushed
the
pavera/update-cache-if-zero-install
branch
from
d88f9eb to
96560c1
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5946
Context
Previously we were using
--mode=update-lockfileto limit the changes made by Dependabot to only the lockfile updates. This proved insufficient for users with yarn's zero install configured. This PR removes that flag and includes.pnp.cjschanges in the resulting PRsApproach
We considered adding a conditional to only remove this flag if the repo had a .yarn/cache dir, but we found that this flag is also not supported in yarn v2 which would further complicate the conditional, and through testing found that the performance improvement of using the flag was pretty small (around 10s per dependency).
Due to the above we opted to remove our usage of the flag for all cases.