Fix crash when updating Python libraries with multiple manifest types #5932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Setting as draft because I'm not sure this is desired behavior. Nobody has complained about this so maybe best to not create the PR and just skip the crash. |
|
I reviewed the repository where I observed this, and repo maintainer was happily merging dependabot PRs before this bug appeared. So I say let's go with this approach and restore those PRs. |
pavera
reviewed
Oct 20, 2022
pavera
approved these changes
Oct 20, 2022
If a library has both a pyproject.toml file and a standard
requirements.txt file, we'd end up using the `:widen` strategy for the
dependencies in the `requirements.txt` file and eventually crashing with
an error like the following:
```
/home/dependabot/dependabot-core/common/lib/dependabot/update_checkers/base.rb:266:in `block in preferred_version_resolvable_with_unlock?': undefined method `[]' for nil:NilClass (NoMethodError)
updated_requirements.none? { |r| r[:requirement] == :unfixable }
^^^^^^^^^^^^^^
from /home/dependabot/dependabot-core/common/lib/dependabot/update_checkers/base.rb:266:in `none?'
from /home/dependabot/dependabot-core/common/lib/dependabot/update_checkers/base.rb:266:in `preferred_version_resolvable_with_unlock?'
from /home/dependabot/dependabot-core/common/lib/dependabot/update_checkers/base.rb:249:in `numeric_version_can_update?'
from /home/dependabot/dependabot-core/common/lib/dependabot/update_checkers/base.rb:199:in `version_can_update?'
from /home/dependabot/dependabot-core/common/lib/dependabot/update_checkers/base.rb:44:in `can_update?'
from bin/dry-run.rb:709:in `block in <main>'
from bin/dry-run.rb:661:in `each'
from bin/dry-run.rb:661:in `<main>'
```
I think the crash happens because the requirements.txt file updater does
not supoort the `:widen` strategy. So my fix is to fallback to
`increase` in this case, since requirements.txt files usually include
pinned dependencies so widening probably doesn't make much sense there.
deivid-rodriguez
force-pushed
the
deivid-rodriguez/python-crash
branch
from
7a25e2c to
7d91b71
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered this issue while wrapping up #5661. However, the issue is already there so I think it makes sense to extract it to its own PR.
If a library has both a pyproject.toml file and a standard requirements.txt file, we'd end up using the
:widenstrategy for the dependencies in therequirements.txtfile if the project is a library, and eventually crashing with an error like the following:I think the crash happens because the requirements.txt file updater does not supoort the
:widenstrategy. So my fix is to fallback toincreasein this case, since requirements.txt files usually include pinned dependencies so widening probably doesn't make much sense there.