Fix Maven inability to overwrite repository urls by ID #5878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakecoffman
force-pushed
the
jakecoffman/maven-overwrite-repository-by-id
branch
from
cd042df to
14f53fa
Compare
jakecoffman
force-pushed
the
jakecoffman/maven-overwrite-repository-by-id
branch
from
14f53fa to
afcf67d
Compare
jeffwidman
changed the title
mctofu
approved these changes
Oct 12, 2022
| @@ -36,27 +37,39 @@ def initialize(dependency_files:, evaluate_properties: true) | |||
|
|
|||
| # Collect all repository URLs from this POM and its parents | |||
| def repository_urls(pom:, exclude_inherited: false) | |||
| repo_urls_in_pom = | |||
| entries = gather_repository_urls(pom: pom, exclude_inherited: exclude_inherited) | |||
| urls = Set.new | |||
There was a problem hiding this comment.
ids might be a better name since we store the ids in it?
jakecoffman
force-pushed
the
jakecoffman/maven-overwrite-repository-by-id
branch
from
afcf67d to
2e4650d
Compare
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Maven, it is possible to overwrite repository URLs defined elsewhere by defining a repository with the same ID, as long as the file has precedence according to the order defined in the docs.
This is often used to define a different central repository to replace the default one inherited from the Super POM:
In this PR, I've tried to honor that behavior by gathering the IDs along with the URL and deduplicate by ID according to that precedence.
One caveat is that Maven differentiates between repository and pluginRepository. Our code does not, so if central is overwritten in a repository it will also overwrite it in pluginRepository. It seems somewhat unlikely that only one or the other is overwritten, so I think this is probably ok for now.