Fixed disabledPackageSources for nuget.org #5874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mctofu
reviewed
Oct 12, 2022
jakecoffman
dismissed
their stale review
David is correct, something fishy is going on here
mctofu
reviewed
Oct 13, 2022
nuget/spec/dependabot/nuget/update_checker/repository_finder_spec.rb
Outdated
Show resolved
Hide resolved
jakecoffman
reviewed
Oct 18, 2022
jakecoffman
reviewed
Oct 18, 2022
honeyankit
force-pushed
the
honeyankit/nuget-support-for-disable-registry
branch
from
385f9b4 to
ef24824
Compare
honeyankit
force-pushed
the
honeyankit/nuget-support-for-disable-registry
branch
from
ef24824 to
e49c6ff
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the nuget.config, adding the default public Nuget registry to
disabledPackageSourcessection was not disabling it. Dependabot was still able to access the default public registry (nuget.org).With this modification, the dependabot won't contact the default public registry if a user disable the public nuget registry in the
disabledPackageSourcessection even without using the<clear />tag in the nuget.config. [ref]