swap history file from byebug to new debug gem
#5855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
commented
Oct 8, 2022
| @@ -19,7 +19,6 @@ vendor | |||
| /.vscode/ | |||
| /.vscode-server/ | |||
| /.vscode-server-insiders/ | |||
| .byebug_history | |||
There was a problem hiding this comment.
Moving the location was intentional, as it seemed to fit better next to the rspec file and not within these directories.
jakecoffman
approved these changes
Oct 10, 2022
`byebug` was replaced with the new `debug` gem as part of the `ruby` `3.1` upgrade. So swap out the history file locations in `.gitignore` to the new one... see `RUBY_DEBUG_HISTORY_FILE` default value [here](https://github.com/ruby/debug#configuration-list). This was originally removed in https://github.com/dependabot/dependabot-core/pull/4567/files#diff-2f754321d62f08ba8392b9b168b83e24ea2852bb5d815d63e767f6c3d23c6ac5L19, then put back in 847d111#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947R20. However, the last trace of `byebug` was removed from `Gemfile.lock` in https://github.com/dependabot/dependabot-core/pull/5849/files#diff-0c7825d57fc79377b294d76c04d7bf63931bba3e9cd7946e19b5d3cb955c5548L144, so it's now safe to remove the history file. This was originaly
jeffwidman
force-pushed
the
jeffwidman-patch-3
branch
from
65dfc41 to
18b4d20
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
byebugwas replaced with the newdebuggem as part of theruby3.1upgrade.So swap out the history file locations in
.gitignoreto the new one... seeRUBY_DEBUG_HISTORY_FILEdefault value here.This was originally removed in https://github.com/dependabot/dependabot-core/pull/4567/files#diff-2f754321d62f08ba8392b9b168b83e24ea2852bb5d815d63e767f6c3d23c6ac5L19, then put back in 847d111#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947R20.
However, the last trace of
byebugwas removed fromGemfile.lockin https://github.com/dependabot/dependabot-core/pull/5849/files#diff-0c7825d57fc79377b294d76c04d7bf63931bba3e9cd7946e19b5d3cb955c5548L144, so it's now safe to remove the history file.