Yarn Berry: Prevent sub-package dependencies being added to root workspace #5829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jurre
force-pushed
the
jurre/yarn-berry-fix-workspace-deps
branch
from
6524dab to
32c1c4c
Compare
mctofu
approved these changes
Oct 3, 2022
jurre
force-pushed
the
jurre/yarn-berry-fix-workspace-deps
branch
from
32c1c4c to
d72decf
Compare
…space Previously, when attempting to update a sub-packages' dependency, it would unintentionally get added to the top-level workspaces' `dependencies` in the yarn lockfile. This happened because we ran `yarn add` instead of `up`, which adds it to the top-level package (and then updates the other existing instances), we then discard the package.json changes, so those never got committed, but the entry in the lockfile remains, putting it in an inconsistent state.
jurre
force-pushed
the
jurre/yarn-berry-fix-workspace-deps
branch
from
d72decf to
6b61bfc
Compare
mctofu
approved these changes
Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when attempting to update a sub-packages' dependency, it would unintentionally get added to the top-level workspaces'
dependenciesin the yarn lockfile.This happened because we ran
yarn addinstead ofup, which adds it to the top-level package (and then updates the other existing instances), we then discard the package.json changes, so those never got committed, but the entry in the lockfile remains, putting it in an inconsistent state.