[pub] Log the Dart / Flutter SDK version selected #5748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurre
reviewed
Sep 19, 2022
pub/lib/dependabot/pub/helpers.rb
Outdated
| @@ -138,9 +144,12 @@ def ensure_right_flutter_release | |||
| end | |||
|
|
|||
| parsed = JSON.parse(stdout) | |||
| flutter_version = parsed["frameworkVersion"] | |||
| dart_version = parsed["dartSdkVersion"].split.first | |||
There was a problem hiding this comment.
Suggested change
| dart_version = parsed["dartSdkVersion"].split.first | |
| dart_version = parsed["dartSdkVersion"]&.split&.first |
Should we add this to safe-guard against parsed["dartSdkVersion"] being nil? This would now raise an error if it's nil.
There was a problem hiding this comment.
We should always have a dart version. I made the check such that the error message will become nicer.
|
Thanks @sigurdm! I noticed there are a few linter violations that you'll see in the CI output, they should be easy to fix up but lmk if I can help. I also notice this breaks a (new) end-to-end test: Which hints that this might be causing the job to fail, I left an in-line comment about what could potentially cause an issue here, but I may be off. |
|
Now it seems to pass checks. PTAL |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix of #5396