Fix commitlint message style detection #5744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
deivid-rodriguez/commitlint-messages
branch
3 times, most recently
from
91ff710 to
c317b7f
Compare
landongrindheim
approved these changes
Sep 19, 2022
common/spec/dependabot/pull_request_creator/message_builder_spec.rb
Outdated
Show resolved
Hide resolved
deivid-rodriguez
force-pushed
the
deivid-rodriguez/commitlint-messages
branch
6 times, most recently
from
2823cdb to
216d0a9
Compare
deivid-rodriguez
force-pushed
the
deivid-rodriguez/commitlint-messages
branch
from
216d0a9 to
bb709f3
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not try to be too smart since there's too many different commitlint setups. Instead, it seems more sound to use the style of previous commits.
Also, I think commit message should default to use the configured prefix for development dependencies if
prefixis configured, butprefix-developmentis not.This is just a naive approach that works with
bin/dry-run.rbbut probably specs need fixing, etc.Fixes #1666.