-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump activesupport from 6.1.4.4 to 7.0.4 in /updater #5704
Bump activesupport from 6.1.4.4 to 7.0.4 in /updater #5704
Conversation
03ef177
to
a117c24
Compare
9c52a60
to
47327e5
Compare
51b146c
to
231c961
Compare
b4ee500
to
4db820c
Compare
@dependabot rebase |
eed040a
to
f15f6a9
Compare
Bumps [activesupport](https://github.com/rails/rails) from 6.1.4.4 to 7.0.4. - [Release notes](https://github.com/rails/rails/releases) - [Changelog](https://github.com/rails/rails/blob/v7.0.4/activesupport/CHANGELOG.md) - [Commits](rails/rails@v6.1.4.4...v7.0.4) --- updated-dependencies: - dependency-name: activesupport dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
bd0d354
to
429bead
Compare
@@ -2,6 +2,7 @@ | |||
|
|||
require "terminal-table" | |||
require "dependabot/api_client" | |||
require "active_support/core_ext" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is necessary to import delegate
... for some reason it was working fine without an explicit import under v6
, but under v7
requires an explicit import.
Smoke test failure for
|
Re-running the failing I also tried running the test against However, clicking into the results shows that they all immediately passed because path filtering skipped the runs... At first I assumed I needed to add an
AFAICT, that should bypass the filtering such that the smoke tests should fully execute when manually triggered... But yet they didn't. 🤔 For now I'd like to get this shipped, and then will dig further into this later this week as I assume it will keep cropping up on future PR's. |
Interestingly, the I don't know why it repeatedly failed on this PR. |
That was because of path filtering... those other PR's didn't touch the I chatted with Jake and he already took a shot at fixing that to mark itself as skipped but ran into difficulties. I've been bit by this several times in dev/staging and now here in prod, so I'll take another shot at it and maybe ping the actions team to see if there's a workaround. |
Bumps activesupport from 6.1.4.4 to 7.0.4.
Release notes
Sourced from activesupport's releases.
... (truncated)
Changelog
Sourced from activesupport's changelog.
... (truncated)
Commits
8015c2c
Version 7.0.4ff27758
Revert "Merge pull request #44695 from Edouard-chin/ec-tagger-logger-broadcast"4a1f224
Merge pull request #45882 from rails/short-inspect-on-test-casea3bd3b5
Backport Redis 5.0 compatibility67f37ac
Fix flaky tests for RedisCacheStorec520e38
Document AS::Cache::MemCacheStore#write options [ci-skip]a74b650
Document AS::Cache::Store#initialize options [ci-skip]f7a82bf
Document AS::Cache::Store#read options [ci-skip]414351f
Rewrite AS::Cache::Store#fetch options doc as list [ci-skip]2661d22
Consolidate AS::Cache::Store#write documentation [ci-skip]Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)