Rename phpstan.neon -> phpstan.dist.neon
#5692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed this new config file location is used in https://github.com/dependabot/dependabot-core/actions/runs/3041184101/jobs/4898047993#step:6:6746: |
Per https://phpstan.org/config-reference#config-file: > The usual practice is to have `phpstan.neon.dist` or `phpstan.dist.neon` > under version control, and allow the user to override certain settings > in their environment (on their own computer or on a continuous > integration server) by creating `phpstan.neon` that’s present in > `.gitignore` file. I picked `phpstan.dist.neon` for consistency with `.php-cs-fixer.dist.php` config (dependabot#5691). I didn't add the file to `.gitignore` because I actually want to know if there starts being a new file under that name and see it in git...
jeffwidman
force-pushed
the
rename-phpstan.neon-phpstan.dist.neon
branch
from
b74b87e to
58e4526
Compare
jakecoffman
approved these changes
Sep 13, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://phpstan.org/config-reference#config-file:
I picked
phpstan.dist.neonfor consistency with.php-cs-fixer.dist.phpconfig (#5691).I didn't add the file to
.gitignorebecause I actually want to know if there starts being a new file under that name and see it in git...