Testing new ruby #5451
Closed
Testing new ruby #5451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
force-pushed
the
testing-new-ruby
branch
from
ba8e034 to
b748f6f
Compare
jeffwidman
commented
Jul 30, 2022
| @@ -35,8 +35,6 @@ Gem::Specification.new do |spec| | |||
| spec.add_dependency "parser", ">= 2.5", "< 4.0" | |||
| spec.add_dependency "toml-rb", ">= 1.1.2", "< 3.0" | |||
|
|
|||
| spec.add_development_dependency "debase", "0.2.3" | |||
| spec.add_development_dependency "debase-ruby_core_source", "0.10.16" | |||
There was a problem hiding this comment.
Note to myself when I put together the "real" PR:
- added in https://github.com/dependabot/dependabot-core/pull/5086/files
- debase doesn't currently support Ruby 3 or 3.1: Segmentation fault in Ruby 3.1.0 / RubyMine debugger ruby-debug/ruby-debug-ide#223 (comment)
- ruby 3 ships with a new
debuggem? don't have many details on it... - not sure if we should also remove
ruby-debug-ideor at least bump the version pin: https://github.com/dependabot/dependabot-core/pull/5086/files#diff-e843e646a7311fb218cf05845818b31d84bc04c0742f0567395c0c289cacf72cR46
but we shouldn't need debase, it's only for debugging and we can always add it back later when they add support...
jeffwidman
force-pushed
the
testing-new-ruby
branch
from
b748f6f to
80c364b
Compare
|
Had to temp drop the ubuntu 22.04 image in my testing as I ran into an erlang problem, and the first thing we want to do is get ruby working, then will deal with erlang etc 22.04 issues... hopefully I don't get a chicken-and-egg where the Ruby bump requires 22.04... |
jeffwidman
force-pushed
the
testing-new-ruby
branch
from
fa7a25f to
200bd6d
Compare
`webrick` was removed from the `ruby` `3.0` stdlib, so must be manually installed. It's only needed by `pub`, and only as a dev server used in tests, so added it only for that specific ecosystem as a development dependency.
jeffwidman
force-pushed
the
testing-new-ruby
branch
from
ff379ac to
5dbc2d1
Compare
|
Closing as I got this PR to a point where everything other than Rubocop is passing... the remaining work to make this mergable will be handled in a less scattered manner over in #5447 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doing some testing against CI for #5447