-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gradle] Handle plugin version variables without string interpolation #5381
[Gradle] Handle plugin version variables without string interpolation #5381
Conversation
@brrygrdn any chance to get some eyes on this one? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hey there, sorry for the slow review.
This is great, super straightforward and nice job with the tests.
Can you rebase to fix the merge conflict?
Done @jeffwidman ✅ |
Thanks! Looks like tests are still failing though? Also, can you explain why the tests need the length changed? I assumed originally that was related to a regex change capturing an additional character which gets parsed out, but since it's no longer doing that, makes me realize I don't know why the length change is/isn't needed? |
Yeah I see that, I'll take a look later and try and fix it. It's been a few months so my memory is a bit hazy.
That was exactly the intention at the time. I'll have to dig in and check why it's not working anymore. |
Hey @jeffwidman, finally had some time to look into it. Turns out I messed up on the rebase and had a question mark in the wrong place for the regex. Should be good to go now 👌 |
@jeffwidman @bdragon any chance for another review 🙏🏻 The MR had to be updated with master again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me.
Thanks!
Fixes #4127
This change allows direct variables in place of versions to be used in Gradle Plugins scope without the need to redundantly interpolate them in a string.
This PR addresses the following issue:
Does not work - versions are ignored by Dependabot:
Works as a workaround - versions are picked up correctly: