Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workaround for broken ruby gems compare #4933

Conversation

jeffwidman
Copy link
Member

@jeffwidman jeffwidman commented Mar 31, 2022

This was added in cdb346e as a temporary workaround
until rubygems/rubygems#2651 shipped.

It looks like that shipped in Ruby Gems 3.1.0, and Dependabot is currently on
Ruby Gems 3.2.20:

&& gem update --system 3.2.20 \

So this should be safe to remove.

Note that I removed the code workaround from the original commit, but
not the test cases... so they should catch any regressions.

This was added in
dependabot@cdb346e
as a temporary workaround until rubygems/rubygems#2651 shipped.

It looks like that shipped in Ruby Gems 3.1.0, and Dependabot is
currently on Ruby Gems `3.2.20`: https://github.com/dependabot/dependabot-core/blob/9c090f6fe573aa3b6b05d20920c7c48f5f00403f/Dockerfile#L77

So this should be safe to remove.

Note that I removed the code workaround from the original commit, but
not the test cases... so they should catch any regressions.
@jeffwidman jeffwidman requested a review from a team as a code owner March 31, 2022 00:10
Copy link
Member

@landongrindheim landongrindheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@landongrindheim landongrindheim merged commit 45592e3 into dependabot:main Mar 31, 2022
@jeffwidman jeffwidman deleted the remove-outdated-local-fix-for-version-compare branch March 31, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants