Remove unnecessary get_directory special cases for npm_and_yarn

[ianlyons]

• The underlying DefinitelyTyped issue was resolved in microsoft/types-publisher@910368a
• The underlying Gatsby issue was resolved in gatsbyjs/gatsby@d6d18e2

[ianlyons]

I didn't see any tests that exercised this case, but let me know if I missed something!

[jurre]

Thanks @ianlyons!

[Nishnha]

Looks like we can remove this line too

Suggested change

source_from_url = Source.from_url(get_url(details))

[ianlyons]

Ah yep, on it

…

On Mon, Mar 14, 2022 at 12:53 PM Nish Sinha ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In npm_and_yarn/lib/dependabot/npm_and_yarn/metadata_finder.rb <#4840 (comment)> : > @@ -123,18 +123,6 @@ def get_url(details) def get_directory(details) source_from_url = Source.from_url(get_url(details)) Looks like we can remove this line too ⬇️ Suggested change - source_from_url = Source.from_url(get_url(details)) — Reply to this email directly, view it on GitHub <#4840 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAN4NEZVBFJIUO53I5PQQHTU75VJFANCNFSM5QSCYSNQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[ianlyons]

@jurre are those bundler CI failures mine? happy to dig in

[ianlyons]

@jurre anything else I need to do to get this in?

[jurre]

@jurre anything else I need to do to get this in?

No, apologies I just lost track of this one. I've rebased it and set up automerge for when CI passes

[yeikel]

@jurre a review is still needed for auto merge to work