Treat GHES hosted sources as github sources #4335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brrygrdn
approved these changes
Oct 20, 2021
|
I need to fix up a bunch of tests that now attempt to check if the unknown host is GHES, on it 👍 |
jurre
force-pushed
the
jurre/ghes-host
branch
from
db3ab88 to
bc03df9
Compare
When a dependency is hosted on GHES, previously it was not treated as a GitHub source, meaning that we would not check for releases/changelogs etc when requesting Metadata for the PR. This fixes that, by first parsing the URL, and then making a request to `<host>/status`, and checking for a `X-GitHub-Request-Id` header, which we return from GitHub Enterprise Server.
jurre
force-pushed
the
jurre/ghes-host
branch
from
bc03df9 to
7fe1474
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a dependency is hosted on GHES, previously it was not treated as a
GitHub source, meaning that we would not check for releases/changelogs
etc when requesting Metadata for the PR.
This fixes that, by first parsing the URL, and then making a request to
<host>/status, and checking for aX-GitHub-Request-Idheader, whichwe return from GitHub Enterprise Server.