Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Gradle files with no top level build.gradle file #4256

Merged
merged 2 commits into from
Oct 7, 2021

Conversation

zbynek
Copy link
Contributor

@zbynek zbynek commented Sep 25, 2021

Fixes #3908

Allows fetching and parsing projects with missing top level build.gradle file, as long as they have one or more subprojects defined in settings.gradle.

Manually tested by downgrading one dependency and letting dependabot update it again: https://github.com/zbynek/selenium-webdriver-java/pull/1/files

@zbynek zbynek requested a review from a team as a code owner September 25, 2021 22:59
Copy link
Member

@jurre jurre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks again @zbynek

Small request for future PRs: if you could split up any refactoring into separate commits from the ones that add/change functionality it would make reviewing a little easier 🙇

@jurre jurre merged commit 120d80d into dependabot:main Oct 7, 2021
@zbynek zbynek deleted the settings-only branch October 7, 2021 17:53
@jurre jurre mentioned this pull request Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Gradle multi-projects
2 participants