bin/dry-run.rb requires a development container to run #4215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brrygrdn
commented
Sep 10, 2021
brrygrdn
force-pushed
the
brrygrdn/dry-run-requires-dev-shell
branch
from
a6cb175 to
6e18a6f
Compare
jurre
reviewed
Sep 10, 2021
bin/dry-run.rb
Outdated
| @@ -35,6 +35,15 @@ | |||
|
|
|||
| # rubocop:disable Style/GlobalVars | |||
|
|
|||
| unless File.exist?("/etc/dependabot-core-dev") | |||
There was a problem hiding this comment.
WDYT about checking if the user is dependabot instead?
[dependabot-core-dev] ~/dependabot-core $ whoami
dependabot
There was a problem hiding this comment.
Yeah, I like that, it saves the hassle of having to rebuild images
jurre
approved these changes
Sep 10, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it is possible to run
bin/dry-run.rbon a native machine, it requires the user to correctly install native dependencies, such as the right versions of package managers and so on to be guaranteed to match a 'real' Dependabot run.Since we use this tool as a first line debugging step, it often adds friction to the process of reproducing builds if a native environment is used.
In order to reduce context and make this process more confident, let's make it a requirement the script is ran using the developer shell so we default to reproducible outcomes.