Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most important change of the PR is to each ecosystem's
script/ci-test
scripts, introduced in #3426 . We want these shells to exit on the first non-zero status, not to return the status of their last command.The previous version of these scripts masked problems:
rubocop
was ignored. I noticed this as style: use consistent indentation for first element #3649 changed rules and passed CI - but produced a diff when auto-applying locally.python
ecosystem, thepylint
status was ignored. I fixed a whitespace issuebundler
ecosystem, the status ofrspec
is ignored - we'd removed some required fixtures and were looking for some fixtures in the wrong place.Sorry for the meandering scope: it's fixing the CI script to detect problems, then trying to find a minimal resolution to problems that have crept in.