-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support gradle kotlin #2680
Support gradle kotlin #2680
Conversation
7b11463
to
83de89d
Compare
Thanks for the contribution @shakhar! I'm a bit worried about the entire test suite being duplicated, that means that we'll have to maintain and run twice the number of test cases, even though the code is only slightly different. How do you feel about adding a few high level test cases for kotlin, and maybe some specific edge-cases? As long as the code that was introduced is covered that would be sufficient IMO |
4ded747
to
4a0d8f1
Compare
Amazing work on this @shakhar, we'll need a few days to test/review this but it's greatly appreciated! cc @thepwagner would love to get your 👀 on this as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! 🎉
I've made some inline comments, my biggest concern is around the syntax for maps not matching what I recall from Kotlin.
4a0d8f1
to
4c2831c
Compare
Hey @jurre and @thepwagner, Is there some news about your testing of this feature? |
@shakhar sorry for the delay, it may be a few weeks before we can loop back to test this. |
@jurre @thepwagner Any updates? (not rushing just checking if you have some news 😃 ) |
Hi @shakhar, we're planning to figure out what additional work adding support for kotlin will be on our side, and then hopefully I can give you a better answer. Your work is definitely very much appreciated! 💛 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all your hard work on this PR @shakhar!
I've been testing it out with main
using the bin/dry-run.sh
script for some recent Dependabot jobs.
I only found one minor issue which I've highlighted below. I'm running the specs to check reasoning that it's just an RSpec issue.
Once that is fixed, I think we can go ahead and
Co-authored-by: Barry Gordon <[email protected]>
ccf58f6
to
d425a96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shakhar! This looks ready to - I'll start rolling forward on a release
Thanks a lot for the work! 🏅 |
Gradle Kotlin's build files have a little bit different formatting that Dependabot does not support yet.
In the following PR I done some changes and additions in the existing gradle code to support gradle kotlin files.
These are the main changes:
.gradle.kts
suffix and support all regex parsing that different from groovy.*.gradle
files to*.gradle.kts
files